Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Multiple Amped Weapons Timers #500

Merged
merged 17 commits into from
Jan 3, 2023
Merged

Conversation

GalacticMoblin
Copy link
Contributor

@GalacticMoblin GalacticMoblin commented Sep 8, 2022

Applies the missing signal from the code for the Amped Weapons timer.

(Using another amped weapons boost before the last one ends would make the effect end prematurely when the original timer ended, this PR fixes that)

(if I broke any other changes, whoops)

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if somebody could test this more thoroughly than my limited testing, that would be appreciated

Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is looking good, can't test rn

@BobTheBob9
Copy link
Member

will merge once conflicts are solved

JMM889901 and others added 6 commits November 12, 2022 14:15
* Upload cl_titan_cockpit.nut

* Add eject string in script

* Moved to client

* index issue + removed else so always returns

* Apply suggestions from code review

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Rest of the suggestions 

because github makes me want to cry

* Commit suggestions from review

GitHub really hates batching suggestions

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
@uniboi
Copy link
Contributor

uniboi commented Dec 10, 2022

changes from this pr have already been merged.

@GalacticMoblin
Copy link
Contributor Author

I fixed this PR to do what I said it should do

Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code still looks good

@GalacticMoblin
Copy link
Contributor Author

@GeckoEidechse
Copy link
Member

@BobTheBob9 merge conflicts have been resolved :>

@BobTheBob9 BobTheBob9 merged commit a203eea into R2Northstar:main Jan 3, 2023
GeckoEidechse pushed a commit that referenced this pull request Jan 4, 2023
* Add files via upload

* Delete _burnmeter.gnut

* Add files via upload

Fixed multiple Amped Weapon uses not resetting the timer

* Add eject quotes (#527)

* Upload cl_titan_cockpit.nut

* Add eject string in script

* Moved to client

* index issue + removed else so always returns

* Apply suggestions from code review

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Rest of the suggestions 

because github makes me want to cry

* Commit suggestions from review

GitHub really hates batching suggestions

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Add files via upload

* Delete _burnmeter.gnut

* Rename _burnmeter.gnut.txt to _burnmeter.gnut

* Update _burnmeter.gnut

* Update _burnmeter.gnut

* Update _burnmeter.gnut

* Update _burnmeter.gnut

Co-authored-by: JMM889901 <41163714+JMM889901@users.noreply.github.com>
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants