Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW] Enable Turrets By Default #587

Merged
merged 3 commits into from Feb 27, 2023
Merged

[FW] Enable Turrets By Default #587

merged 3 commits into from Feb 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2023

Current FW mega turrets're diabled until they first seeing an enemy, make them unable to be damaged at start, which is confusing

@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Feb 1, 2023
GeckoEidechse
GeckoEidechse approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

Tested in 1-player listen server. Pre-PR enemy base turrets would need to "wake up" before shooting and taking damage. With PR applied they seem to be always active.

@GeckoEidechse GeckoEidechse added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Feb 2, 2023
@GeckoEidechse
Copy link
Member

Need someone to do code review and then it should be ready to merge ^^

Dinorush
Dinorush approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@Dinorush Dinorush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation on the pre-existing code could be adjusted to match the rest of the code, but otherwise the code itself looks fine to me.

EladNLG
EladNLG approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@EladNLG EladNLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With exceptions, looks good to me.

Northstar.Custom/mod/scripts/vscripts/gamemodes/_gamemode_fw.nut Outdated Show resolved Hide resolved
@GeckoEidechse GeckoEidechse removed the needs code review Changes from PR still need to be reviewed in code label Feb 22, 2023
EladNLG
EladNLG requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@EladNLG EladNLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accident :(

@GeckoEidechse GeckoEidechse self-requested a review February 27, 2023 10:34
GeckoEidechse
GeckoEidechse approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes were addressed. Re-testing since last commit is not necessary as the only things changed are indentation and comments.

@GeckoEidechse GeckoEidechse merged commit afea353 into R2Northstar:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeckoEidechse @EladNLG @Dinorush