Improve server connection error messages #598
Conversation
It's already used for self auth and is available for both, but we currently only show it for the former.
It never fully worked, and it's more useful to have non-localized detailed error messages.
pg9182
changed the title
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
|
i did not mean to approve this i meant to do requires changes FUCK |
pg9182
force-pushed
the
ms-serverconn-err
branch
from
4fc3396 to
2f613e5
Compare
pg9182
force-pushed
the
ms-serverconn-err
branch
2 times, most recently
from
83ebf63 to
2907d9c
Compare
The message always contains something like it, and it's always right after a connectiom anyways.
pg9182
force-pushed
the
ms-serverconn-err
branch
from
2907d9c to
fb87dbb
Compare
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
F1F7Y
added
the
almost ready to merge
|
Waiting on @BobTheBob9 to be able to merge |
GeckoEidechse
dismissed
BobTheBob9’s stale review
Requested changes have been addressed
GeckoEidechse
removed
the
almost ready to merge
| dialogData.message = Localize("#NS_SERVERBROWSER_CONNECTIONFAILED") + "\nERROR: " + reason + "\n" + Localize("#" + reason) | ||
| dialogData.message = reason |
There was a problem hiding this comment.
This, combined with R2Northstar/NorthstarLauncher@009482f, was a bad change that is causing some issues with helping users.
- No localisation for the error reason
- No longer shows the error code
- Doesn't show the "Connection failed!" localisation, users don't know what happened
Before:
Connexión fallida!
ERROR: PLAYER_NOT_FOUND
No se encontró la cuenta del jugador
After:
Couldn't find player account
There was a problem hiding this comment.
I like no localization more tbh
There was a problem hiding this comment.
It's objectively worse for users. All helpers need is the error code so it doesn't affect them (except all our docs and stuff were based around the error code, which is no longer shown to the user at all)
There was a problem hiding this comment.
We definitely should at the very least include the unlocalized error code.
We could also do something like this:
Connection failed! // Localized message
Code: <code> // Unlocalized code
Check 'wiki.northstar.tf/error_codes' for possible solutions // Localized message
There was a problem hiding this comment.
My current thoughts is that we should move the "Connection failed!" bit to the header of the dialog as well.
Currently it looks like
ERROR // header
Couldn't find player account
Before it looked like
ERROR // header
Connection failed! // localised
ERROR: PLAYER_NOT_FOUND
Couldn't find player account // localised
IMO, it should look more like
Connection Failed! // header
Couldn't find player account // localised
Error code: PLAYER_NOT_FOUND
Check 'wiki.northstar.tf/error_codes' for possible solutions // localised
There was a problem hiding this comment.
Either way, launcher should be passing an error code if possible, not just a message
The error messages from atlas imo should be reserved for extra debugging information, and the error codes used to generate localised text
There was a problem hiding this comment.
Something like this could be good, since this isnt a disconnect dialog we can add more buttons and do stuff like opening links. Could be good to get fewer people asking for help in discord?
It's already used for self auth and is available for both, but we currently only show it for the former.
recommends R2Northstar/NorthstarLauncher#433