Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Triple Threat animations #599

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Add Triple Threat animations #599

merged 4 commits into from
Mar 9, 2023

Conversation

Masterliberty
Copy link
Contributor

@Masterliberty Masterliberty commented Mar 8, 2023 •
edited by GeckoEidechse
Loading

triple threat w anims

Triple Threat now rotates when aiming down sights like it does in Titanfall1.

@Masterliberty
Add files via upload
a9bc621 
triple threat w anims
@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Mar 8, 2023
Masterliberty and others added 3 commits March 8, 2023 14:55
@Masterliberty
Add files via upload
8f19b1e
@Masterliberty
Arc Cannon Restore
6d4b950 
Arc Cannon with anims, proper fixes to not crash tf2, and tf1 stats.
@Masterliberty
Removed the arc cannon commit until Triple Threat is merged.
80cf76d 
Removed the arc cannon commit until Triple Threat is merged.
GeckoEidechse
GeckoEidechse approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

Before PR:
https://user-images.githubusercontent.com/40122905/223873782-0512354d-9799-4e0f-8c99-e7f6872b0e47.mp4

With PR:
https://user-images.githubusercontent.com/40122905/223873794-6d62ad45-cc31-4e1f-a906-06bc56be4ef4.mp4

Compatibility with older clients was also tested and works.

@GeckoEidechse GeckoEidechse removed the needs testing Changes from the PR still need to be tested label Mar 9, 2023
@GeckoEidechse GeckoEidechse changed the title Added Triple Threat with anims. Add Triple Threat animations Mar 9, 2023
@GeckoEidechse GeckoEidechse merged commit 967889c into R2Northstar:main Mar 9, 2023
@GeckoEidechse GeckoEidechse removed the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Mar 9, 2023
@ghost ghost mentioned this pull request Mar 29, 2023
Closed
GeckoEidechse pushed a commit that referenced this pull request Apr 18, 2023
@Masterliberty @GeckoEidechse
Add Triple Threat animations (#599)
4c6bd94 
* Add files via upload

triple threat w anims
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Masterliberty @GeckoEidechse