Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a server crash caused by missing arg len check #614

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

ScureX
Copy link
Contributor

@ScureX ScureX commented Apr 14, 2023

image

no this doesnt work in vanilla i tried but mayb im stupifd so feel fre e to try again

interesting article: https://www.buzzfeed.com/pablovaldivia/cats-nice-and-jerks

image

https://www.buzzfeed.com/caseyrackham/cutes-pure-cats

Copy link
Member

@BobTheBob9 BobTheBob9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing

@BobTheBob9 BobTheBob9 merged commit 16656ea into R2Northstar:main Apr 14, 2023
@GeckoEidechse GeckoEidechse changed the title lolololol server crasher hehe hooo Fix a server crash caused by missing arg len check Apr 16, 2023
@GeckoEidechse
Copy link
Member

Diff with the actual fix

9f4ce9d...f10e143

GeckoEidechse pushed a commit that referenced this pull request Apr 18, 2023
* why dont we have this fucking file

* the actual fix

* why is it fukcing formatted liek taht
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants