Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fastball respawning spectating player #616

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Fix Fastball respawning spectating player #616

merged 1 commit into from
Apr 15, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

should close #615

F1F7Y
F1F7Y approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, didnt test

@ASpoonPlaysGames
Copy link
Contributor Author

Code looks good, didnt test

thank you i worked on the code for ages

GeckoEidechse
GeckoEidechse reviewed Apr 15, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping testing cause this is a simple fix

@GeckoEidechse GeckoEidechse changed the title fix dumb bug in fastball spectating Fix Fastball respawning spectating player Apr 15, 2023
@GeckoEidechse GeckoEidechse merged commit f7b0e6f into R2Northstar:main Apr 15, 2023
GeckoEidechse pushed a commit that referenced this pull request Apr 18, 2023
@ASpoonPlaysGames @GeckoEidechse
Fix Fastball respawning spectating player (#616)
4034da5
wolf109909 pushed a commit to R2NorthstarCN/NorthstarMods that referenced this pull request May 1, 2023
@ASpoonPlaysGames @wolf109909
Fix Fastball respawning spectating player (R2Northstar#616)
86a09e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse left review comments

@F1F7Y F1F7Y F1F7Y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spectators in fastball respawn
3 participants
@ASpoonPlaysGames @GeckoEidechse @F1F7Y