Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert 'Hardpoint UI Fixes (#416)' (#618)" #619

Merged
merged 14 commits into from
Apr 22, 2023
Merged

Revert "Revert 'Hardpoint UI Fixes (#416)' (#618)" #619

merged 14 commits into from
Apr 22, 2023

Conversation

x3Karma
Copy link
Contributor

@x3Karma x3Karma commented Apr 20, 2023

Replaced the SetPlayerNetInt inside of a player check so other entities would not trigger the crash.

Full changelogs in #416.

@pg9182 pg9182 self-requested a review April 20, 2023 06:36
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Apr 20, 2023 •
edited
Loading

For anyone reviewing the change from #416 is e5de5a6

And for anyone testing, the crash was on colony.

@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Apr 20, 2023
catornot
catornot approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on colony and some other maps with bots and I didn't get any crashes.

@pg9182 pg9182 added needs testing Changes from the PR still need to be tested and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Apr 20, 2023
F1F7Y
F1F7Y requested changes Apr 21, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking untill discord conversation is resolved. ( link )

F1F7Y
F1F7Y approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing

pg9182
pg9182 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@pg9182 pg9182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested launching a few maps; everything seems to work fine.

@pg9182 pg9182 added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Apr 21, 2023
@pg9182
Copy link
Member

pg9182 commented Apr 21, 2023

@R2Northstar/mods-maintainers feel free to merge this so it can be included in v1.13.

cc @GeckoEidechse

@GeckoEidechse GeckoEidechse merged commit 64b666d into R2Northstar:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catornot catornot catornot approved these changes

@F1F7Y F1F7Y F1F7Y approved these changes

@pg9182 pg9182 pg9182 approved these changes

Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@x3Karma @GeckoEidechse @pg9182 @catornot @F1F7Y