Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix titan-only boosts for modes like LTS #678

Merged
merged 5 commits into from
Oct 8, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Jul 30, 2023

Hopefully closes #667

The original check Respawn did for this was:

if ( Riff_TitanAvailability() == eTitanAvailability.Never )
{
	//JFS: Batteries and Titan turrets are useless in PvP, turn them into amped weapons instead. Not an elegant solution at all. Fix next game. (Make boosts editable mid-match? )
	if ( ref == "burnmeter_emergency_battery" || ref == "burnmeter_at_turret_weapon"  )
		ref = "burnmeter_amped_weapons"
}

This was changed in #71 to the current check, which is incorrect.

This PR will need testing, unfortunately it is hard to test LTS by myself. We need to ensure that titans cannot be earned in LTS.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jul 30, 2023
@catornot catornot self-requested a review August 29, 2023 22:10
Copy link
Contributor

@NoCatt NoCatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, essentially the same thing but rules out more errors, as its guaranteed that you can't spawn Titan in.
Will be testing later today

@ASpoonPlaysGames ASpoonPlaysGames added vanilla parity and removed needs code review Changes from PR still need to be reviewed in code labels Sep 3, 2023
Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.

tested this pr with bots couldn't get a new titan in lts and boosts didn't transfer over matches.

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested labels Sep 5, 2023
@GeckoEidechse
Copy link
Member

Merging based on reviews.

@GeckoEidechse GeckoEidechse merged commit 612e6a1 into R2Northstar:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now vanilla parity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Why no Titan Turrets in LTS?
4 participants