Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash with IsPetTitan #701

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Fix a crash with IsPetTitan #701

merged 1 commit into from
Sep 17, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

if titan.GetTitanSoul() returned null (non-pet NPC titan for example) this function would crash when it really shouldn't.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 4, 2023
NoCatt
NoCatt approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@NoCatt NoCatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added line checks if the titan has a valid soul, follows formatting conventions of other scripts.
Not tested but I mean its 2 lines ( surely that has never gone wrong )

@ASpoonPlaysGames ASpoonPlaysGames removed the needs code review Changes from PR still need to be reviewed in code label Sep 4, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

Since @Zanieon was the one who brought this issue to my attention, I would appreciate if you could run a small test?

@Zanieon
Copy link
Contributor

Zanieon commented Sep 4, 2023

About to run a test right now

Zanieon
Zanieon approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No crashes so far, good to go!

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested labels Sep 4, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

can github actions function please thanks

GeckoEidechse
GeckoEidechse approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-off approval based on the fact that other people already reviewed it. I didn't properly code review nor test this.

@GeckoEidechse GeckoEidechse merged commit 0068720 into R2Northstar:main Sep 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoCatt NoCatt NoCatt approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@Zanieon Zanieon Zanieon approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ASpoonPlaysGames @Zanieon @GeckoEidechse @NoCatt