Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the Triple Threat's world model not working properly when used by an AI opponent #704

Merged

Conversation

GalacticMoblin
Copy link
Contributor

@GalacticMoblin GalacticMoblin commented Sep 6, 2023

Recompiled and edited the Triple Threat's world model to fix an unhandled animation event error

How to easily replicate the issue solo:

  • Bring down a titan and enter it
  • use sv_cheats 1 and give mp_titanweapon_triple_threat to give your titan the Triple Threat
  • exit your titan, aim at your titan and use ent_fire !picker setteam 2 to set it to the opposite team
  • Let it (attempt to) shoot you with the Triple Threat

(Issue also occurs if you use the Triple Threat world model on any other gun)

Closes #606

GalacticMoblin and others added 23 commits September 8, 2022 04:38
Fixed multiple Amped Weapon uses not resetting the timer
* Upload cl_titan_cockpit.nut

* Add eject string in script

* Moved to client

* index issue + removed else so always returns

* Apply suggestions from code review

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Rest of the suggestions 

because github makes me want to cry

* Commit suggestions from review

GitHub really hates batching suggestions

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Fixes the Arc Cannon crash to do with dying while the beam is active
@GalacticMoblin GalacticMoblin changed the title Fix for the Triple Threat's world model not working when used by an AI opponent Fix for the Triple Threat's world model not working properly when used by an AI opponent Sep 6, 2023
@ASpoonPlaysGames ASpoonPlaysGames added the needs testing Changes from the PR still need to be tested label Sep 6, 2023
@ASpoonPlaysGames
Copy link
Contributor

Not adding "needs code review" because this is just a binary file change

Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated testing instructions

While in your titan:

  1. script TakeAllWeapons(GetPlayerArray()[0]);
  2. give mp_titanweapon_triplethreat.

Media

Before PR

image

My auto-titan would look at me and do nothing.

After PR

image

My auto-titan would fire grenades at me (doing no damage though, because it's my titan I guess).

@Alystrasz Alystrasz added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested labels Nov 6, 2024
@GeckoEidechse GeckoEidechse merged commit 0528f9f into R2Northstar:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

NPC Titans can't fire triple threat
6 participants