Fix players dying when mantling on props or embarking Titans in mp_complex3
#709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
approved these changes
Sep 13, 2023
ASpoonPlaysGames
added
the
needs testing
|
Adding "needs testing" because I would kinda like a second person to test this (the person I saw testing in discord was @Zanieon who is the author of the PR) |
|
Alright changed method of fixing the problem to what @ASpoonPlaysGames suggested, now it really needs a testing from another person other than me to see if everything is still alright. |
ASpoonPlaysGames
added
the
commits vanilla file
uniboi
approved these changes
Sep 14, 2023
ASpoonPlaysGames
added
READY TO MERGE
GeckoEidechse
changed the title
mp_complex3
GeckoEidechse
changed the title
mp_complex3mp_complex3
GeckoEidechse
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Confirmed working in testing. I simply replicated the bug without the PR shown in the screenshot by mantling the couch table and getting killed by the trigger in the process.
With the PR installed I no longer get killed.
I did not look at the actual ent file so no "code review" done by me..
GeckoEidechse
removed
the
commits vanilla file
|
Original vanilla file has been committed in c7149b7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a whole
trigger_hurtright below the ground in the inner large hallway which whenever a player tries to mantle on any of the props in there either intentionally or by accident they will instantly die. This also applies to when you embark your titan in there. This does not happen on vanilla servers.This PR removes the trigger that kills the player.