-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Launch Multiplayer" button #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want some feedback from other contributors on that. I agree that having Launch Multiplayer in there is kinda stupid.
On the flipside having Launch Vanilla in there and then locking it makes it seem that we are "trying to prevent players from playing vanilla" or are "planning to add vanilla support" or sth (which tbf is a whole-ass different discussion that currently goes into the direction of "maybe" I think?
Maybe we should just remove the non-Northstar button entirely?
TL;DR: better than before I guess. We could do better still IMO. Whether that's this PR or a different one, I guess that's the question ^^
In my opinion, either remove the Vanilla Multiplayer button entirely or rename it to vanilla. |
Remove entirely |
I'd remove entirely unless we get around to adding proper vanilla support in the near future (which is not in 2032 when Northstar 2.0 releases). |
Remove entirely, or rename to "Launch Official Multiplayer". Or if possible, could we just add a popup when you click it that tells you you're heading to official servers and not community ones? |
i like the idea of removing it more, creates less confusion than what we have now while also not trying to make it look like vanilla compat is "just around the corner" or something |
I vote for temporary removal, until we get vanilla compatibility working. |
Yeah, gonna rewrite this to remove the button given the feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, just comments out the multiplayer button and all relevant code with comments that explain why.
Merging based on reviews and discussion. |
closes #711
Small localisation change, hopefully will reduce some tickets?
Will also be nice for if/when we get vanilla compatibility