Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dropships immune to Titan step damage #737

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

closes #364

Currently dropships take damage from titans stepping on them, this prevents that

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 5, 2023
@GeckoEidechse GeckoEidechse changed the title Make dropships immune to titan step damage Make dropships immune to Titan step damage Oct 7, 2023
@Zanieon Zanieon added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 15, 2023
Co-authored-by: William Miller <william-millennium@hotmail.com>
@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Oct 15, 2023
@GeckoEidechse
Copy link
Member

Note to self, Zanieon did code review and tested with the PR changes.

They spawned dropships with ent_create and it wouldn't take step damage from Northstar Titan (flew up to dropship with hover ability and landed on it)

@GeckoEidechse GeckoEidechse merged commit 6df399f into R2Northstar:main Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Stepping on the evac dropship as a titan damages it.
3 participants