Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Award titan assist stats based on titan soul damage history #746

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Award titan assist stats based on titan soul damage history #746

merged 1 commit into from
Oct 17, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

Change split from #744

Titans stores damage history in their Soul component, not the NPC itself, probably due to how game handles pilot/auto-titan interaction with the Titan entities.

This means that we weren't awarding assist stats properly for titan assists

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 14, 2023
@ASpoonPlaysGames ASpoonPlaysGames mentioned this pull request Oct 14, 2023
Merged
Zanieon
Zanieon approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ingame, stats tracking properly as it should.

@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 14, 2023
@ASpoonPlaysGames

This comment was marked as off-topic.

Sign in to view
@GeckoEidechse
Copy link
Member

Merging based on reviews

@GeckoEidechse GeckoEidechse merged commit 327e40e into R2Northstar:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zanieon Zanieon Zanieon approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @GeckoEidechse @Zanieon