Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging invalid map/mode exception in progression #750

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Oct 18, 2023

Some game modes like Gun Game or Infection are not considered valid yet, causing the warning message to be spammed in the logs.

Necessary work should be done to add the modes to the list of valid modes. Until we will just comment out the print statement in order to prevent log spam.

closes #749

no, this doesn't need code review, nor does it need testing. its literally commenting out a print statement

@ASpoonPlaysGames ASpoonPlaysGames added the READY TO MERGE This mergeable right now label Oct 18, 2023
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply comments out a print statement. No testing needed.

@GeckoEidechse GeckoEidechse merged commit d84d875 into R2Northstar:main Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Gun game server spams Invalid enum or item name in logs
2 participants