Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restricting Aegis Rank reset functionality to MP #771

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix restricting Aegis Rank reset functionality to MP #771

merged 2 commits into from
Dec 18, 2023

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Dec 17, 2023

I actually forgot to move up the MP check to prevent the Aegis Rank Reset function to be restricted to MP only, trying to play the campaign without that restriction doesn't let the game load the maps.

@GeckoEidechse GeckoEidechse changed the title [Hotfix] Aegis Rank Reset Functionality not restricted to MP. Fix restricting Aegis Rank reset functionality to MP Dec 18, 2023
GeckoEidechse
GeckoEidechse approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing. Before this PR SP fails to launch due to script compile error. After this PR it work again just fine.

There's not much to code review here as it simple moves the compiler flag further up.

@GeckoEidechse GeckoEidechse merged commit a169e16 into R2Northstar:main Dec 18, 2023
4 checks passed
@Zanieon Zanieon deleted the aegisreset_hotfix branch December 18, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zanieon @GeckoEidechse