Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlayerInventory_TakeAllInventoryItems not being threaded #852

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

x3Karma
Copy link
Contributor

@x3Karma x3Karma commented Aug 30, 2024

The reason this needs to be threaded is because on L157, it performs a waitthread on a function, which will cause an error.

image

The reason this needs to be threaded is because on L157, it performs a `waitthread` on a function, which will cause an error.
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😹

@F1F7Y
Copy link
Member

F1F7Y commented Aug 30, 2024

why does the joy cat emote on discord look so shit

@ASpoonPlaysGames
Copy link
Contributor

I'd say that this doesn't need testing. Using thread on a function can't ever really hurt.

@ASpoonPlaysGames ASpoonPlaysGames added the READY TO MERGE This mergeable right now label Aug 30, 2024
@GeckoEidechse GeckoEidechse changed the title Fix PlayerInventory_TakeAllInventoryItems not being threaded Fix PlayerInventory_TakeAllInventoryItems not being threaded Aug 31, 2024
@GeckoEidechse GeckoEidechse merged commit e253357 into R2Northstar:main Aug 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants