Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is IsValidPlayer() check #855

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add is IsValidPlayer() check #855

merged 1 commit into from
Aug 30, 2024

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Aug 30, 2024 •
edited
Loading

Add is IsValidPlayer() check to prevent potential script crash

Taken from #830

@Zanieon
Add is IsValidPlayer() check
9e72cdc 
to prevent potential script crash
GeckoEidechse
GeckoEidechse commented Aug 30, 2024
View reviewed changes
Copy link
Member Author

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from #830 written by @Zanieon. Change looks fine and is just an additional validity check so no testing needed.

@GeckoEidechse GeckoEidechse merged commit 3318280 into main Aug 30, 2024
7 checks passed
@GeckoEidechse GeckoEidechse deleted the fix/add-is-valid-player-check branch August 30, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeckoEidechse @Zanieon