Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the the text for the "Join" button #877

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Conversation

eve-v0
Copy link
Contributor

@eve-v0 eve-v0 commented Sep 10, 2024

Update server_browser.menu
Makes text in "Join" button allign to middle/north which looks better
image

Splitting into separate prs as requested by gecko
Link to old PR #874

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 10, 2024
@GeckoEidechse GeckoEidechse changed the title Update server_browser.menu - Align the the text for the "Join" button Align the the text for the "Join" button Sep 10, 2024
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As reviewed in #874, button text is now centered.

@Alystrasz Alystrasz added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 4, 2024
@GeckoEidechse
Copy link
Member

Whoops this kinda got overlooked, sorry. Merging o7

@GeckoEidechse GeckoEidechse merged commit d35ce2d into R2Northstar:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants