Add completed and started signals to Action #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryonoff
changed the title
| @@ -14,6 +14,26 @@ extension Action { | |||
| public static var rex_disabled: Action { | |||
| return Action(enabledIf: ConstantProperty(false)) { _ in .empty } | |||
| } | |||
|
|
|||
| /// Whether the action execution was completed succesfully. | |||
There was a problem hiding this comment.
You have a typo here.
succesfully → successfully
There was a problem hiding this comment.
Thank you! Fixed it.
|
@larryonoff I really like this! Could you add some tests as well? |
|
Sure. Will do it a bit later. |
|
@RuiAAPeres Just added tests. |
|
|
||
| func testCompleted() { | ||
| let (producer, sink) = SignalProducer<Int, TestError>.buffer(Int.max) | ||
| let action = Action { producer } |
There was a problem hiding this comment.
could you change sink to observer. The sink nomenclature was abandoned a while back. (ReactiveCocoa/ReactiveCocoa#2475)
There was a problem hiding this comment.
Sure. Will do it in 2 hours.
|
@larryonoff could you rebase? |
larryonoff
force-pushed
the
feature/extend-action
branch
from
86f0459 to
b3b6e29
Compare
|
@RuiAAPeres rebase done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This PR adds
completedandstartedsignals toAction. I often use emptyActionas a trigger that some logic should begin executing. So these two properties were introduced.