Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rex_selectedSegmentIndex for UISegmentedControl #126

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

iv-mexx
Copy link
Member

@iv-mexx iv-mexx commented Jun 7, 2016

Title says it all

@iv-mexx iv-mexx force-pushed the feature/UISegmentedControl branch 4 times, most recently from bf3f662 to 2f10b36 Compare June 8, 2016 12:11
@iv-mexx
Copy link
Member Author

iv-mexx commented Jun 8, 2016

Hm, the first CI fails were because I've added UISegmentedControl to all targets instead of only to the iOS target. I've already fixed that.

But now, it seems to still fail for the tvOS target:

-> Rex (0.10.0)
- ERROR | [tvOS] xcodebuild: Returned an unsuccessful exit code. You can use --verbose for more information.
- ERROR | [tvOS] xcodebuild: /Users/travis/build/neilpa/Rex/Source/UIKit/UISegmentedControl.swift:16:21: error: use of unresolved identifier 'rex_controlEvents'>

even though the UISegmentedControl.swift is not added to the tvOS target anymore 😕

@iv-mexx iv-mexx force-pushed the feature/UISegmentedControl branch from 2f10b36 to 489b3dd Compare June 8, 2016 12:44
@iv-mexx
Copy link
Member Author

iv-mexx commented Jun 8, 2016

Oh nevermind, i guess UISegmentedControl.swift needs to be explicitly excluded for the tvOS target in the Podspec.

@neilpa
Copy link
Member

neilpa commented Jun 8, 2016

Oh nevermind, i guess UISegmentedControl.swift needs to be explicitly excluded for the tvOS target in the Podspec.

I've hit this problem a couple times too. One of the reasons I'm not a fan of pods since you have multiple project definitions.

@neilpa neilpa merged commit c14d2df into RACCommunity:master Jun 8, 2016
@neilpa
Copy link
Member

neilpa commented Jun 8, 2016

@iv-mexx I invited you as a collaborator to the repo. Feel free to review and merge PRs since I'm not as on top of them these days.

@iv-mexx
Copy link
Member Author

iv-mexx commented Jun 8, 2016

@neilpa Cool, thanks 😃 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants