Property predicates #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting! |
These optimizations avoid extra layers of AnyProperty wrapping when combining longer chains of the same type.
|
I like this also. Is this still a work in progress? |
|
@mpurland Not really, I was just sitting on it while I contemplated further generalizations to the code. E.g. It may be possible to abstract this into a generic property combining mechanism but there's a few hairy bits I haven't worked out in my head. Regardless, this is useful enough as is so I'll go ahead and merge it. I'll also try to cut a new build, especially since there's a new RAC alpha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gist of what I was talking about in #46. Have ideas for improving the interface since you shouldn't need to use the
PredicateTypestructs directly.