Fix breathing and skin temperature convertors #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpgxvii
reviewed
Mar 21, 2024
| .map(tryOrNull(m -> parseBr(m, startDate, timeReceived), | ||
| (a, ex) -> logger.warn("Failed to convert breathing rate from request {}, {}", request, a, ex))); | ||
| } | ||
|
|
||
| private TopicData parseBr(JsonNode data, ZonedDateTime startDate, double timeReceived) { | ||
| Instant time = startDate.with(LocalDateTime.parse(data.get("dateTime").asText())).toInstant(); | ||
| Instant time = LocalDate.parse(data.get("dateTime").asText()).atStartOfDay(ZoneOffset.UTC).toInstant(); |
There was a problem hiding this comment.
Does this have to be at start of day?
There was a problem hiding this comment.
The dateTime is in YYYY-MM-DD format and atStartOfDay get the 12.00 am timestamp.
There was a problem hiding this comment.
Oh ok I see, I didn't realise it didn't have the time and only the date.
mpgxvii
reviewed
Mar 21, 2024
| @@ -22,7 +22,7 @@ object Versions { | |||
| const val okhttp = "4.11.0" | |||
|
|
|||
| const val firebaseAdmin = "9.1.0" | |||
| const val radarSchemas = "0.8.7-SNAPSHOT" | |||
| const val radarSchemas = "0.8.6" | |||
There was a problem hiding this comment.
Should we update this to the latest one? 0.8.7-hotfix
There was a problem hiding this comment.
0.8.7-hotfix doesn't work for me. I revert it to the working version.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.