Impl. configuration of application loop and user cache refresh durations #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h intervals Needed for efficient e2e testing.
yatharthranjan
approved these changes
Nov 19, 2024
|
@yatharthranjan I have updated the README as per your suggestion. I will merge this PR. |
pvannierop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At present the interval between refresh actions of the registered FitBit users is hard-coded and of very long (1hr). This makes using the FitBit connector in an e2e-test difficult.
Solution
This PR will allow external configuration the 1) main application loop and 2) expiry of the FitBit user cache. This way e2e-tests can use shorter refresh intervals.