Do not retry failed authorization #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivemaham
reviewed
Sep 6, 2021
| } | ||
|
|
||
| @Override | ||
| public String getAccessToken(User user) throws IOException, NotAuthorizedException { | ||
| if (!user.isAuthorized()) { |
There was a problem hiding this comment.
Just wondering, How would this prevent temporary failures when refreshing tokens being completely removed out of the system? In this case the researchers have to recruit again.
There was a problem hiding this comment.
Indeed, but temporary failures are handled by the rest source authoriser. This update is just to ensure that unauthorised users do not pulled again and again. If the rest source authoriser fails to update a token because it gets a 400, 401 or 403 error from the REST source API (e.g. Fitbit), it will permanently mark the user as unauthorised, until the user is manually authorised again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore users for future requests if their authentication has failed.