Migrate Structopt to clap #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king-11
force-pushed
the
king-11/migrate-structopt
branch
from
33cc9e4 to
850340e
Compare
|
👏 (sorry, couldn't help myself). LGTM :D |
|
I didn't quite get what was the sorry for 🫠 but thanks for quick review 😃 |
|
|
|
😂 okay got it now 👏🏻 |
|
Concept ack There is a format error, and an example to be fixed to make the CI happy |
king-11
force-pushed
the
king-11/migrate-structopt
branch
2 times, most recently
from
2b91432 to
aadd8d7
Compare
structopt has been deprecated in favour of clap hence migrating to it Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
allow env_logger support for larger number of versions Changelog-Changed: migrate to use clap instead of structopt as it is deprecated Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
king-11
force-pushed
the
king-11/migrate-structopt
branch
from
aadd8d7 to
78cf0bb
Compare
|
fixed the example and formatting too |
|
@RCasatta can you run the workflow now 😅 |
RCasatta
approved these changes
Nov 14, 2024
|
sure no worries just glab I could contribute will work on the crate separation part now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #89