Fix n3 parser exponent syntax of floats with leading dot. #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Apr 17, 2020
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
|
Hopefully I'm not being annoying, but as I was looking at this I wanted to add some tests that should have caught this problem earlier. Made a proposal at white-gecko#1. |
TEST: Stress test exponent regex
|
@effigies everything fine. We are happy about all good contributions. |
effigies
reviewed
Apr 17, 2020
test/test_n3.py
Outdated
| exps = ("1", "12", "+1", "-1", "+12", "-12") | ||
| for parts in itertools.product(signs, mantissas, es, exps): | ||
| expstring = "".join(parts) | ||
| self.assertRegex(expstring, exponent_syntax) |
There was a problem hiding this comment.
Suggested change
| self.assertRegex(expstring, exponent_syntax) | |
| self.assertIsNotNone(exponent_syntax.match(expstring)) |
There was a problem hiding this comment.
I used assetTrue and assertFalse which are effectively doing the same.
test/test_n3.py
Outdated
| # Add test cases as needed | ||
| invalid = (".e1",) | ||
| for expstring in invalid: | ||
| self.assertNotRegex(expstring, exponent_syntax) |
There was a problem hiding this comment.
Suggested change
| self.assertNotRegex(expstring, exponent_syntax) | |
| self.assertIsNone(exponent_syntax(expstring)) |
nicholascar
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Thanks @effigies and @white-gecko for the quick fix! (come on @edmondchuc, you found this, should have fixed it!)
|
@effigies nice find with the regex. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #999 .