Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1043. #1054

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Fixes #1043. #1054

merged 3 commits into from
Sep 18, 2020

Conversation

achaudhary997
Copy link
Contributor

* Added test case for RDFLib#1043
* Don't make XSD.Decimal pretty during serialization
@coveralls
Copy link

coveralls commented May 19, 2020

Coverage Status

Coverage increased (+0.004%) to 75.654% when pulling 932710a on achaudhary997:fix1043 into 231bc6d on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 75.654% when pulling c7c4e15 on achaudhary997:fix1043 into 231bc6d on RDFLib:master.

@nicholascar
Copy link
Member

@achaudhary997 please merge in master branch since a whole host of changes were recently merged in to remove Python 2 code. Looks like you will have a conflict or two to resolve also. This will trigger a re-checking of the code by Travis. Then it may be ready for merging.

rdflib/term.py Outdated Show resolved Hide resolved
@nicholascar
Copy link
Member

We've done testing: it looks like the ".0" should be added but only if there is no decimal point and no e or E.

@ashleysommer
Copy link
Contributor

I've merged latest master changes into this, and resolved the conflict. I also took the opportunity to make the change myself that was suggested above:

the ".0" should be added but only if there is no decimal point and no e or E.

I'll double check that the test passes, then merge this.

@ashleysommer ashleysommer merged commit 7289f68 into RDFLib:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants