#747 Create new GregorianType class in extras/gregorianType.py to add…

[prince17080]

… gYear and gYearMonth types

Create new GregorianType class in extras/gregorianType.py to add gYear and gYearMonth types

Signed-off-by: Prince Sachdeva prince17080@iiitd.ac.in

Closes #747

[coveralls]

Coverage decreased (-0.07%) to 75.698% when pulling f64eb1f on prince17080:GH-747-add-gYear-gYearMonth into 037ea51 on RDFLib:master.

[nicholascar]

Hi @prince17080, Thanks for this PR - we agree that i's a good idea to have handling for gYear & gMonth.

However, there are two issues with this PR:

1. You need to rebase it to current master status
2. We don't agree with the use of a special class for just handling these two literals and prefer extending the use of the mapper. Why cant you just created two parsing functions, perhaps parse_gyear & parse_gyearmonth?

[nicholascar]

@prince17080 I'll close this soon (a week?) if I don't here back from you here.

[nicholascar]

closing as no response from raiser and this work is likely superseded by other gYear/gMonth worm already merged