-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serialize with multiple disks on windows #1172
Conversation
Hi @urbanmatthias Also, just a note, this works with Windows paths too: A good middleground for this fix might be to test |
Co-authored-by: Ashley Sommer <ashleysommer@gmail.com>
Yes you are right, thanks. I applied your suggested changes. |
Need review from one more Maintainer before we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. I folowed back through graph.py to check all the URL parsing etc. and I think this will work fine.
@nicholascar |
Fixes #1170
Proposed Changes
I replaced the
path
variable in theshutil.move
call withlocation
.The former is the output of an
urlencode
call, which strips the drive letter on windows machines.If the user has multiple drives,
shutil.move
will fail if the drive letter is not there.