Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance 13% on the rdflib-benchmark with the default (memory) store and a store size of 4k.
Moving straight to
collections.ChainMap
was considered butBindings
behaves differently when one key is in multiple dicts, as they are iterated over multiple times and also counted on__len__
multiple timesI do think that the differences for
__len__
and__iter__
are unintentional / bugs. If so, I would rework this MR to fix those.