Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset graph on exit from context #1206

Merged
merged 2 commits into from
Dec 27, 2020
Merged

Reset graph on exit from context #1206

merged 2 commits into from
Dec 27, 2020

Conversation

sa-bpelakh
Copy link
Contributor

Fixes #1205

Proposed Changes

  • After the body of the GRAPH clause is evaluated, restore the context graph value before returning the result.
  • Tested both fixed and variable graph specifications for coverage.

@coveralls
Copy link

coveralls commented Dec 2, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 75.446% when pulling c27da15 on sa-bpelakh:graph-filter-query into c5ff127 on RDFLib:master.

@sa-bpelakh sa-bpelakh closed this Dec 10, 2020
@sa-bpelakh sa-bpelakh reopened this Dec 10, 2020
nicholascar
nicholascar approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The Travis test failure is due only to connection issues in Travis, not anything here in the code so I approve. Awaiting second review.

@nicholascar
Copy link
Member

Thanks Boris!

@nicholascar nicholascar merged commit 009dc24 into RDFLib:master Dec 27, 2020
@white-gecko white-gecko added this to the rdflib 6.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholascar nicholascar nicholascar approved these changes

@white-gecko white-gecko Awaiting requested review from white-gecko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rdflib 6.x.x
Development

Successfully merging this pull request may close these issues.

Named graph erroneous persists in query evaluation context
4 participants
@sa-bpelakh @coveralls @nicholascar @white-gecko