-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle encoding of base64Binary Literals #1258
Conversation
Thank you very much for your contribution :-) This is a case I have not encountered so far. Could you please provide a test that shows what was failing before and that it is fixed now? |
Will there be any interference with #1222 ? |
The test is by analogy with the existing test_hex_binary (minus the integer stuff that relies on hex-specific features of |
I don't believe so, the issue is not with the serialization per se, rather that encoding was not defined for |
@white-gecko @ashleysommer this PR is still pending on your reviews |
This PR has had a couple of reviews, passes all tests and introduces more tests, so I'm merging. It's pretty low-risk PR too (just an updated Literal type). |
Fixes #1257
Proposed Changes
base64Binary
datatype, by analogy to hexlify/unhexlify forhexBinary
tests pass