Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coverage configuration #1267

Merged

Conversation

white-gecko
Copy link
Member

@white-gecko white-gecko commented Mar 1, 2021

Cleans up some parts of the configuration for code coverage

Proposed Changes

This section appears to be left over. It is only necessary in combination with coverage combine,
which we are not using.
@coveralls
Copy link

coveralls commented Mar 1, 2021

Coverage Status

Coverage increased (+0.08%) to 75.492% when pulling cc0d8b4 on white-gecko:feature/coverage-configuration into 9f0f296 on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 75.492% when pulling cc0d8b4 on white-gecko:feature/coverage-configuration into 9f0f296 on RDFLib:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 75.492% when pulling cc0d8b4 on white-gecko:feature/coverage-configuration into 9f0f296 on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 75.492% when pulling cc0d8b4 on white-gecko:feature/coverage-configuration into 9f0f296 on RDFLib:master.

@nicholascar
Copy link
Member

nicholascar commented Mar 1, 2021

This looks great to me but I'm not really across all this Drone config stuff. I'll be meeting with one of my staff members and other RDFlib contributors (Edmond) on Thursday so I'll go over this then.

I propose that if Ashley approves this, it's all good to go!

@white-gecko
Copy link
Member Author

This does not yet include the configuration of coveralls in drone. I tried to find out how to do that as well, but did not succeed so far. This should be an additional pr to configure the drone setup for coveralls.

@white-gecko white-gecko mentioned this pull request Mar 1, 2021
@white-gecko
Copy link
Member Author

@ashleysommer is this ok for you?

@white-gecko white-gecko merged commit 16b218b into RDFLib:master Mar 5, 2021
@white-gecko white-gecko deleted the feature/coverage-configuration branch March 5, 2021 14:25
@white-gecko white-gecko added this to the rdflib 6.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants