Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transitive_objects/subjects docstrings and signatures #1305

Merged
merged 1 commit into from
May 12, 2021

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 10, 2021

Fixes #1303

Proposed Changes

  • Fix signatures of both methods to use predicate.
  • Fix incorrect docstring for transitive_subjects

This is a breaking change, because signature of a user facing method was changed. (breaks in case of using named attributes.)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 75.444% when pulling 9a64d5e on iafork:fix_docstrings into d4c1eff on RDFLib:master.

@coveralls
Copy link

coveralls commented May 10, 2021

Coverage Status

Coverage remained the same at 75.523% when pulling 9a64d5e on iafork:fix_docstrings into d4c1eff on RDFLib:master.

@aucampia
Copy link
Member Author

@white-gecko hope this is what you had in mind here

Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@white-gecko white-gecko added this to the rdflib 6.0.0 milestone May 12, 2021
@nicholascar
Copy link
Member

Given that test pass there must be none that actually test the transitive_objects or transitive_subjects functions. Pity...

@nicholascar nicholascar merged commit ab48705 into RDFLib:master May 12, 2021
@aucampia
Copy link
Member Author

Given that test pass there must be none that actually test the transitive_objects or transitive_subjects functions. Pity...

Yeah, I looked and I could not find any, will try add some when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transitive methods typo
4 participants