Add special handling for gYear and gYearMonth #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 similar comments
aucampia
force-pushed
the
fix_gYearDate
branch
4 times, most recently
from
b137b90
to
9594ceb
Compare
…Rules This should solve various issues that occur with hanlding of xsd:gYear and xsd:gYearMonth values.
nicholascar
requested review from
white-gecko and
nicholascar
and removed request for
white-gecko
nicholascar
approved these changes
May 17, 2021
There was a problem hiding this comment.
Looks good and addresses some annoying issues. Thanks again @aucampia!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve various issues that occur with hanlding of xsd:gYear
and xsd:gYearMonth values.
Fixes #1228
Fixes #806
Fixes #747
Proposed Changes
xsd:gYearandxsd:gYearMonthin_SpecificPythonToXSDRules