-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup Literal.__hash__ and Literal.__eq__ by accessing directly _da… #1321
Conversation
…tatype and _language.
4 similar comments
It failed only Python 3.7, but 3.6 and 3.8 worked OK. This is strange because the changes are very simple. The failed test is:
I tend to think that it is a transient error related to a temporary network problem. Is it possible to rerun a build on the same PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about the "cannot assign address" test failure you're noticing: that's spurious and won't prevent this PR going through.
Literal.hash and Literal.eq use self.datatype and self. language properties. It is faster to directly use the private members Literal._dataype and Literal.__language.
Test importing orkg.nt
Before:
After: