Replace use of DBPedia with the new SimpleHTTPMock #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping this as draft until #1342 is merged |
aucampia
force-pushed
the
iwana-issue1344
branch
from
2ef3897
to
cebf2fb
Compare
|
@aucampia can you move this out of Draft so we can get these changes in? Love to see progress on those fake address errors made! |
This should eliminate the spurious DBPedia related errors that plagued the CI pipeline. I am deleting `test/test_core_sparqlstore.py` as it does not do anything meaningful as far as I can tell and certainly nothing different from what is being done in `test/test_sparqlstore.py`. Also adds ServedSimpleHTTPMock to testutils.py which inherits from SimpleHTTPMock and adds a http server to it which makes it a bit less fiddly to use in tests.
aucampia
force-pushed
the
iwana-issue1344
branch
from
cebf2fb
to
038a6cd
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of DBPedia with the new SimpleHTTPMock
This should eliminate the spurious DBPedia related errors that plagued
the CI pipeline.
I am deleting
test/test_core_sparqlstore.pyas it does not do anythingmeaningful as far as I can tell and certainly nothing different from
what is being done in
test/test_sparqlstore.py.Also adds ServedSimpleHTTPMock to testutils.py which inherits from
SimpleHTTPMock and adds a http server to it which makes it a bit less
fiddly to use in tests.
Fixes #1344
Proposed Changes
test/test_core_sparqlstore.pythat use dbpedia to use SimpleHTTPMocktest/test_core_sparqlstore.pyas it seems to be doing nothing.testutils.py