test: add skips to accommodate a DBpedia outage #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
aucampia/20230824T2022-dbpedia-resilience
branch
from
3d226c7 to
78a6791
Compare
aucampia
added
review wanted
3 tasks
DBpedia is failing right now. This change adds narrow skips to the tests that use it which only trigger for connection related problems, so the test suite can pass even when DBpedia is down. Test that use external services should be avoided if possible and should be replaced with the HTTP mocking facilities of the test framework.
aucampia
force-pushed
the
aucampia/20230824T2022-dbpedia-resilience
branch
from
78a6791 to
82c7d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
DBpedia is failing right now. This change adds narrow skips to the tests that use it which only trigger for connection related problems, so the test suite can pass even when DBpedia is down.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.