Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ConjunctiveGraph (#2405) #2786

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

wallberg
Copy link
Contributor

Summary of changes

Deprecate ConjunctiveGraph, in favor of Dataset, as per #2405 .

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • [] All tests pass, but lint and mypy do not, I believe due to pre-existing issues.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@wallberg
Copy link
Contributor Author

All tests are passing, but this introduces a large number of new warnings about the deprecation. Should I attempt to suppress all of those warnings, as part of this PR?

@nicholascar
Copy link
Member

@wallberg thanks for this PR, it's been a long tme coming (5 years, 3 RDFLib major versions...).

We have some issues with PRs passing validation just at the moment. When I return from leave, next week, I will try and fix this issue. Then we will need to see this PR pass the test suite again. If you had it passing locally, it likely will pass fine as the errors we are seeing are, I think, environment issues, not code errors.

So please hold tight for a couple of weeks on this and I we will get this PR through likely in June. I'm really looking forward to greatly improving RDFLib's multi-graph support and this is part of the whole task.

@coveralls
Copy link

Coverage Status

coverage: 91.039% (+0.01%) from 91.028%
when pulling 77af618 on wallberg:issue-2405-deprecate-cg
into f6de1f3 on RDFLib:main.

@nicholascar nicholascar merged commit 959dec5 into RDFLib:main Jun 17, 2024
22 checks passed
@wallberg wallberg deleted the issue-2405-deprecate-cg branch July 24, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants