Reduce amount of warnings, especially closing opened file pointers #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could leading to created InputSource being replaced...
joernhees
force-pushed
the
reduce_warnings
branch
from
114c5dd
to
b2f6dc1
Compare
joernhees
added a commit
that referenced
this pull request
Sep 10, 2015
Reduce amount of warnings, especially closing opened file pointers
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after enabling warnings in our test runs in #517 it seems as if there is a huge amount of warning output cause we have deprecation warnings and don't really care to close files we open
see
fixes:
Graph.parse()now takes care that if it opens files it also closes themConjunctiveGraph.parse()takes care not to double open source via args passed toGraph.parse()