-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let paths be comparable against all nodes. Fixes #545 #552
Conversation
Hard to say what happens with master failing ... i'll wait for it to be fixed and rebase :) |
👍 sorry for that... #550 |
py3.4:
i guess this is a symmetry problem... if the first operand is not a also, shouldn't https://github.com/RDFLib/rdflib/blob/master/rdflib/term.py#L171 actually |
Don't ask me why, but returning is correct: https://docs.python.org/2/library/constants.html#NotImplemented I'll look into py3, but not today :) |
ah i didn't know it's actually a keyword and confused it with https://docs.python.org/2/library/exceptions.html#exceptions.NotImplementedError which would need to be raised... |
70a7b8c
to
57e8f71
Compare
The missing part was adding When can we kill 2.6 support? :) |
…se total_ordering
0eda590
to
25bfa5b
Compare
i guess with rdflib 5.0.0 but for now i just fixed it by also defining the other comps... one other thing i noticed looking at this again though: if possible |
let paths be comparable against all nodes. Fixes #545
No description provided.