Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INCHIKEY field gets filled with html content #59

Closed
hechth opened this issue Dec 10, 2021 · 4 comments · Fixed by #64
Closed

INCHIKEY field gets filled with html content #59

hechth opened this issue Dec 10, 2021 · 4 comments · Fixed by #64
Labels
bug Something isn't working

Comments

@hechth
Copy link
Member

hechth commented Dec 10, 2021

In an annotated MSP, there are some INCHIKEY's which are html texts instead of an inchi, see below attached file.

I don't know with which options the file was annotated, so currently can't reproduce the error.

bug_report.txt

@hechth hechth added the bug Something isn't working label Dec 10, 2021
@hechth
Copy link
Member Author

hechth commented Dec 10, 2021

This error occurs when running the CIR: smiles -> inchikey conversion

@xtrojak
Copy link
Collaborator

xtrojak commented Dec 13, 2021

Can you also provide the input file? I cannot reproduce this error.

@xtrojak
Copy link
Collaborator

xtrojak commented Jan 6, 2022

There are some cases when CIR shows help page instead of the result. Compare the following cases:

@xtrojak
Copy link
Collaborator

xtrojak commented Jan 6, 2022

This should be generalised to validate whether, for example, obtained inchi or smiles has valid format. For that, matchms validation functions can be used.

It seems like it detects some issues even for simple molecules (e.g. according to matchms, PubChem's Methane record contains invalid smiles).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants