59 Validate metadata #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for validity (using matchms
|
This functionality assumes that validators provided by |
hechth
approved these changes
Jan 6, 2022
|
I think using the validators from matchms is a good starting point - we can still improve them if necessary or switch to something else when it is needed. |
martenson
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were cases when obtained metadata from a service had incorrect content (e.g. #59). This concerns mostly smiles, inchi, and inchikey, since those have defined form. We have covered this issue by using matchms validators, ensuring that each such attribute is valid.
Close #59.