-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce KEGG ID conversions to BridgeDB service #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test it? Maybe we can add a single unit test and convert a single kegg number or so?
conversions = [('hmdbid', 'pubchemid', 'from_hmdbid'), | ||
('hmdbid', 'chemspiderid', 'from_hmdbid'), | ||
('hmdbid', 'wikidataid', 'from_hmdbid'), | ||
('hmdbid', 'chebiid', 'from_hmdbid'), | ||
('hmdbid', 'keggid', 'from_hmdbid'), | ||
('pubchemid', 'hmdbid', 'from_pubchemid'), | ||
('pubchemid', 'chemspiderid', 'from_pubchemid'), | ||
('pubchemid', 'wikidataid', 'from_pubchemid'), | ||
('pubchemid', 'chebiid', 'from_pubchemid'), | ||
('pubchemid', 'keggid', 'from_pubchemid'), | ||
('chemspiderid', 'hmdbid', 'from_chemspiderid'), | ||
('chemspiderid', 'pubchemid', 'from_chemspiderid'), | ||
('chemspiderid', 'wikidataid', 'from_chemspiderid'), | ||
('chemspiderid', 'chebiid', 'from_chemspiderid'), | ||
('chemspiderid', 'keggid', 'from_chemspiderid'), | ||
('wikidataid', 'hmdbid', 'from_wikidataid'), | ||
('wikidataid', 'pubchemid', 'from_wikidataid'), | ||
('wikidataid', 'chemspiderid', 'from_wikidataid'), | ||
('wikidataid', 'chebiid', 'from_wikidataid'), | ||
('wikidataid', 'keggid', 'from_wikidataid'), | ||
('chebiid', 'hmdbid', 'from_chebiid'), | ||
('chebiid', 'pubchemid', 'from_chebiid'), | ||
('chebiid', 'chemspiderid', 'from_chebiid'), | ||
('chebiid', 'wikidataid', 'from_chebiid') | ||
('chebiid', 'wikidataid', 'from_chebiid'), | ||
('chebiid', 'keggid', 'from_chebiid'), | ||
('keggid', 'hmdbid', 'from_keggid'), | ||
('keggid', 'pubchemid', 'from_keggid'), | ||
('keggid', 'chemspiderid', 'from_keggid'), | ||
('keggid', 'wikidataid', 'from_keggid'), | ||
('keggid', 'chebiid', 'from_keggid'), | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be also at some point made as all possible combinations between the 4 initial identifiers - otherwise all good!
No, we removed all tests which actually rely on the contents of a service response, I think we shouldn't go back to that. |
Added support for KEGG ID conversions to BridgeDB service.
Close #101.