14 asynchronous requests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hechth
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
The actual functionality looks great, the organization is a bit entangled (as we discussed) which could be split up more nicely, but I will create a separate issue for that.
The main idea is that the library code has dependencies to other library objects, instead of being composed by the main application, which makes the code more complex than necessary.
Comment on lines
+54
to
+55
| results += await asyncio.gather(*[self.annotator.annotate(spectra, jobs, repeat) for spectra in | ||
| self.spectrums[size * batch_size:(size + 1) * batch_size]]) |
There was a problem hiding this comment.
This operation is quite complex and could either be fit into multiple lines or into a small helper function with a descriptive name.
As discussed, this might then also move to a different class.
martenson
reviewed
Jun 29, 2021
| @@ -7,23 +7,23 @@ Repository for tool that adds more annotations (e.g. SMILES, InChI, CAS number) | |||
|
|
|||
| ```python | |||
| # import MSP class | |||
| from libs.MSP import MSP | |||
| from libs.Spectra import Spectra | |||
martenson
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchronous rework which allows to execute multiple requests simultaneously. This pull requests solves issue #14. This approach was chosen as this is a typical example where program execution is often waiting for response of a request.
Also issue #11 is targeted but not solved, as this approach speeds up the performance. On the other hand, too many requests at once can overload request volume limitations of a service (e.g. PubChem).
Close #14.