Skip to content

Commit

Permalink
Fix issues issue with HSTS upgrade redirects in firefox
Browse files Browse the repository at this point in the history
  • Loading branch information
eliihen committed Jul 27, 2017
1 parent 99f140f commit e5fddd2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/Response/Redirect.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function Redirect(props) {
>
{response.statusCode}
</Status>
<small> {response.statusLine.replace(/.*\d{3} /, '')}</small>
<small> {response.statusLine && response.statusLine.replace(/.*\d{3} /, '')}</small>
</h3>

<Headers expanded headers={headers} />
Expand Down
7 changes: 4 additions & 3 deletions src/propTypes/redirect.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export const redirectShape = {
documentUrl: string.isRequired,
frameId: number.isRequired,
fromCache: bool.isRequired,
ip: string.isRequired,
method: oneOf(REQUEST_METHODS).isRequired,
originUrl: string.isRequired,
parentFrameId: number.isRequired,
Expand All @@ -19,13 +18,15 @@ export const redirectShape = {
value: string.isRequired,
}).isRequired,
).isRequired,
statusCode: number.isRequired,
statusLine: string.isRequired,
tabId: number.isRequired,
time: number.isRequired,
timeStamp: number.isRequired,
type: string.isRequired,
url: string.isRequired,
// Not present on HSTS upgrade requests in Firefox
ip: string,
statusCode: number,
statusLine: string,
};

export default shape(redirectShape);
Expand Down

0 comments on commit e5fddd2

Please sign in to comment.