Missing scopes on punctuation

[randy3k]

From @chbk on December 7, 2017 23:28

I use r a lot so this package is great, is it still being developed?

If so, I noticed missing scopes on () ,:

sub("_", "", path)
getrootdir(utils::untar(src))
data.frame()
file.exists()

They should be punctuation.definition.parameters.bracket.round.begin|end, punctuation.separator.parameters.comma based on docs.

Copied from original issue: REditorSupport/atom-language-r-legacy#10

[randy3k]

I am sure that @kylebarron and @guillaumechaumet are still working on it.

[randy3k]

From @kylebarron on December 8, 2017 0:31

I've been focusing my efforts recently on Stata packages (1, 2) since I'm required to use that language most of the time in my work. I hope to find time to work on this in the next month or two.

Also note that this currently isn't the repository that language-r is sourced from. See this issue for relevant discussion.

I also just noticed that @lee-dohm archived that repository, so I'm not sure if there's any hope of ever having this copy becoming upstream. Creating a maintained fork might be hard to gain traction.

Thoughts @guillaumechaumet ?

[randy3k]

We are waiting @lee-dohm to transfer the ownership of his repo to REditorSupport so we can inherit the atom package name language-r. I hope that we have already convinced him and showed our interests in maintaining it.

[randy3k]

From @guillaumechaumet on December 8, 2017 6:11

I was working on backticks definition since I have seen some strange behaviour. I will look into language-ruby to find some good examples.

[randy3k]

From @guillaumechaumet on January 9, 2018 17:16

I try to improve r.cson for punctuation definition. I have still an issue with back-tick scope. For example `#variable` appeared as comment where '#variable' don't. Any solution?

[randy3k]

it was fixed on the current master.

[chbk]

@randy3k It's still not working for me

[randy3k]

You are right, I misunderstood the issue.

[randy3k]

It should really be fixed now.

[chbk]

Awesome, thank you!

I just found other missing scopes on commas and semicolons that weren't in the original bug report:

df[1,2];
a[,"weight"];
ifelse(p > median(p), "large", "small");
matrix(c(rep(1:0,3), rep(0:1,3)), ncol=2, byrow=TRUE);

Should I open a new issue for this?

[guillaumechaumet]

You should. But I don't see the point here. Could you give us a normal behavior?

[chbk]

Looks like it's actually a regression:

Before (1.4.0):

After:

Semicolons should be punctuation.terminator.semicolon.
Commas should be punctuation.separator.delimiter.comma inside brackets and punctuation.separator.parameters.comma in function calls.

[guillaumechaumet]

Correction done