Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed AnchoredBundle type in STL library #177

Closed
wants to merge 2 commits into from
Closed

Conversation

dr-orlovsky
Copy link
Member

This doesn't affect the consensus and just adds a type to the STL compiled library which was missed before. It was caused by a Strict types bug which allows referencing a library from a rust code without checking that it include the referenced types from STL (and not rust) representation.

@dr-orlovsky dr-orlovsky added the *consensus* Issues affecting distributed concensus label Oct 18, 2023
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #177 (a5705df) into master (5321fa3) will increase coverage by 0.1%.
Report is 7 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #177     +/-   ##
========================================
+ Coverage    12.8%   12.9%   +0.1%     
========================================
  Files          30      30             
  Lines        3079    3081      +2     
========================================
+ Hits          394     397      +3     
+ Misses       2685    2684      -1     
Flag Coverage Δ
rust 12.9% <100.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/stl.rs 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dr-orlovsky
Copy link
Member Author

Superseded by #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Issues affecting distributed concensus
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant