Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new validation APIs from dependencies #184

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Oct 29, 2023
@dr-orlovsky dr-orlovsky marked this pull request as ready for review October 29, 2023 11:46
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #184 (86d3b9b) into master (de8f0e6) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #184   +/-   ##
======================================
  Coverage    12.8%   12.8%           
======================================
  Files          30      30           
  Lines        3087    3081    -6     
======================================
  Hits          394     394           
+ Misses       2693    2687    -6     
Flag Coverage Δ
rust 12.8% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/validation/status.rs 0.0% <ø> (ø)
src/validation/validator.rs 0.0% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lint error but apart from that LGTM

@dr-orlovsky dr-orlovsky merged commit 1a7fbe4 into master Oct 30, 2023
19 of 20 checks passed
@dr-orlovsky dr-orlovsky deleted the fix/validation-script branch April 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants